parse dash manifest if segment template is out of representation #26
Conversation
|
Works perfectly with my DASH manifest ! Thanks @brignolij ! |
|
Thank you for the contribution! We've just added segment template support so if you can rebase with main again and check I can have a look at the PR then. |
|
Hello @birme we have change some part of the code cause with our stream provider some parts didn't work. And I don't know if it's okay for you but I had change some tests because the player https://web.player.eyevinn.technology/index.html wasn't able to decode url encoded, I hope it'll be good for you. |
|
and in the HLS part I've remove a part because it was already include in the package '@eyevinn/m3u8' |
|
Thanks, we'll review! |
|
Btw. can you rebase, fix linting issues and resolve the conflicts with main first though. |
There was a problem hiding this comment.
The solution is clean and should work as intended for most cases, good job! From what I see however, the baseURL handling could lead to errors in edge cases since it can appear in different contexts throughout the manifests. For the purpose of our proxy, removing the baseURL from the manifest ensures that we always resolve the segment URLs appropriately, instead of parsing the baseURL which can lead to unwanted behavior. If you are curious as to how we solved this same issue, you can peek at main. Other than that, I think it is a good improvement to the codebase!
brignolij
force-pushed
the
improve-dash-manifest-parsing
branch
from
7354b25 to
9431fc1
Compare
brignolij
force-pushed
the
improve-dash-manifest-parsing
branch
from
9431fc1 to
7cbfe18
Compare
|
@ShibireX we rebased our branch. |
|
Sorry, but can you rebase with main again and resolve any conflicts? Thanks |
|
hello @birme, we still do some changes cause with different manifest and provider we have some issues. |
Improve dash parsing by fetching segment template in manifest if located out of representation.